feat: add orderbook API base url #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
anxolin
force-pushed
the
allow-set-your-own-orderbook
branch
from
f4ad40f to
d78c0c7
Compare
mfw78
force-pushed
the
feat-single-chain
branch
from
c9e348d to
fb93a2b
Compare
mfw78
force-pushed
the
allow-set-your-own-orderbook
branch
from
d78c0c7 to
c11503d
Compare
mfw78
approved these changes
Oct 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to set your own Orderbook API URL instead of the default ones from the SDK.
This PR is a follow up on cowprotocol/cow-sdk#177.
The motivation, is to allow to set our service IP instead of the external one, to make the connection more performant.
Bonus
While testing this, i realized that in case of an error, the SDK re-attempts 10 times using exponential backoff. This makes it take too much time in case of an error. I reduced to 5 the attempts, and now it re-attempts, but it will take at most a few seconds instead of 2-3 minutes.
Follow up
After this is merged, we will need to set it up (please, let me do it!)
See
https://cowservices.slack.com/archives/C05RMJB7ZFA/p1697021044757619?thread_ts=1697007472.259279&cid=C05RMJB7ZFA
Test
Pass the
--orderBookApiand make sure it uses the parameterOnce this is in staging we can test this in the infrastructure project.