feat: handle error loading filter config

cowprotocol · Nov 20, 2023 · e1ae9ce · e1ae9ce
1 parent 6daa261
commit e1ae9ce
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 12 deletions.
diff --git a/src/domain/chainContext.ts b/src/domain/chainContext.ts
@@ -31,7 +31,10 @@ import {
   reorgDepth,
   reorgsTotal,
 } from "../utils/metrics";
-import { FilterPolicy, fetchPolicy } from "../utils/policy";
+import {
+  FilterPolicy,
+  fetchPolicy as fetchFilterPolicyConfig,
+} from "../utils/policy";
 
 const WATCHDOG_FREQUENCY = 5 * 1000; // 5 seconds
 
@@ -446,10 +449,16 @@ async function processBlock(
     block.number.toString()
   );
 
-  // Update filter policy
-  const policy = await fetchPolicy(chainId);
-  filterPolicy.setHandlers(policy.handlers);
-  filterPolicy.setOwners(policy.owners);
+  // Get the latest  filter policy
+  const policyConfig = await fetchFilterPolicyConfig(chainId).catch((error) => {
+    console.log(`Error fetching the filter policy config for chain `, error);
+    return null;
+  });
+
+  if (policyConfig) {
+    filterPolicy.setHandlers(policyConfig.handlers);
+    filterPolicy.setOwners(policyConfig.owners);
+  }
 
   // Transaction watcher for adding new contracts
   let hasErrors = false;

diff --git a/src/domain/checkForAndPlaceOrder.ts b/src/domain/checkForAndPlaceOrder.ts
@@ -133,6 +133,7 @@ export async function checkForAndPlaceOrder(
         owner,
         conditionalOrderParams: conditionalOrder.params,
       });
+
       switch (filterResult) {
         case FilterAction.DROP:
           log.debug(
@@ -142,9 +143,9 @@ export async function checkForAndPlaceOrder(
           ordersPendingDelete.push(conditionalOrder);
 
           continue;
-        case FilterAction.IGNORE:
+        case FilterAction.SKIP:
           log.debug(
-            "Skipping conditional order. Reason: AcceptPolicy: IGNORE",
+            "Skipping conditional order. Reason: AcceptPolicy: SKIP",
             conditionalOrder.params
           );
           continue;

diff --git a/src/utils/policy.ts b/src/utils/policy.ts
@@ -1,11 +1,9 @@
-import fetch from "node-fetch";
-
 import { ConditionalOrderParams, SupportedChainId } from "@cowprotocol/cow-sdk";
 
 export enum FilterAction {
-  DROP,
-  IGNORE,
-  ACCEPT,
+  DROP = "DROP",
+  SKIP = "SKIP",
+  ACCEPT = "ACCEPT",
 }
 
 export interface FilterParams {