Update used DB tables list #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrug
approved these changes
Feb 11, 2025
| @@ -1,5 +1,6 @@ | |||
| - markdown: | | |||
| Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable). | |||
| If new tables were added, update the [tables list](https://github.com/cowprotocol/services/blob/main/crates/database/src/lib.rs#L51-L87). | |||
There was a problem hiding this comment.
I'm not sure if specifying line numbers is sensible, as they can change in the future.
MartinquaXD
approved these changes
Feb 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PRs(#3266 and #3276) showed that collecting the DB table names automatically is fragile and might expose unnecessary data. There is still a new role can be added with more tables that will break the initial query again. This PR continues using the static table names approach with the updated DB changes reminder.