Fix the DB table rows metric #3276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
approved these changes
Feb 11, 2025
| struct TableName(String); | ||
|
|
||
| const QUERY: &str = "SELECT tablename FROM pg_tables WHERE schemaname = 'public' AND \ | ||
| tablename NOT LIKE '%flyway%' AND tableowner NOT IN ('rdsadmin', \ |
There was a problem hiding this comment.
This is revealing unnecessary data 🤔 I wonder how critical this is
cc @ahhda
|
After thinking more about this, we should probably revert to the hardcoded tables list as was initially suggested in the original PR. And update the DB changes reminder accordingly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrects #3266 with the following changes:
ExludesFilters out tables withaws-related tables from the query that leads to theinsufficient rightserror.rsadminandcow_protocol_adminowners. This should be a more robust approach since these roles can still add more tables, but adding more roles is controlled.auction_participantsandproposed_trade_executionsto theLARGE_TABLESconstant since their size is 4M+ and 8M+ already. That should slightly reduce the DB load since the count queries for these tables might take more than 5s.