Added auction_id field to /settle and /reveal driver requests.
#3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Jan 8, 2025
|
@cowprotocol/solver can we also make sure colocated solvers also confirmed they are complaint to avoid similar |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of the previous PR #3131 which added
auction_idfield as optional on the driver/settleand/revealrequests. Because this is API breaking change we had to wait for Solvers teams to updated their driver version, so they will support newauction_idfield.Current PR changes
auction_idfield from optional to mandatory and starts sending it from the autopilot.Changes
This is mainly port of PR #3113 which introduced API break (and was reverted with PR #3131) on to the current main branch: updated driver and autopilot DTOs, added code to use these new fields and added additional condition on driver side to verify if provided
solution_idis competing in providedauction_id.OpenAPI definition is already up to date.
How to test
Existing tests, esp.
driver_handles_solutions_based_on_id().