Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
foundry-rs/foundry#8035 changed
anvil
to compute the gas price differently. This seems like a breaking change since under some conditions the new logic computes a different gas price than the original one.This broke 2 of our tests which both involve waiting for the system to flush out cached liquidity data to generate new quotes. For
e2e::e2e quoting::local_node_test
it was enough to just bump the--base-fee
to1
(without breaking any other test) and fore2e::e2e protocol_fee::local_node_combined_protocol_fees
I needed to make the condition to detect flushed liquidity stricter.Instead of waiting for any change in quotes (which are now triggered too early because of tiny changes in the gas price) we now wait for the quote to be at least twice as good as the old quote.
Changes
--base-fee
to1
inanvil
argse2e::e2e protocol_fee::local_node_combined_protocol_fees