Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI after foundry update #2771

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Fix CI after foundry update #2771

merged 2 commits into from
Jun 6, 2024

Conversation

MartinquaXD
Copy link
Contributor

Description

foundry-rs/foundry#8035 changed anvil to compute the gas price differently. This seems like a breaking change since under some conditions the new logic computes a different gas price than the original one.

This broke 2 of our tests which both involve waiting for the system to flush out cached liquidity data to generate new quotes. For e2e::e2e quoting::local_node_test it was enough to just bump the --base-fee to 1 (without breaking any other test) and for e2e::e2e protocol_fee::local_node_combined_protocol_fees I needed to make the condition to detect flushed liquidity stricter.
Instead of waiting for any change in quotes (which are now triggered too early because of tiny changes in the gas price) we now wait for the quote to be at least twice as good as the old quote.

Changes

  • bump --base-fee to 1 in anvil args
  • stricter synchronization logic for e2e::e2e protocol_fee::local_node_combined_protocol_fees
  • use nightly version of foundry again in CI

Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, also a comment on the new_market_order_quote.quote.buy_amount > market_quote_before.quote.buy_amount * 2 would be helpful.

@MartinquaXD MartinquaXD enabled auto-merge (squash) June 6, 2024 07:47
@MartinquaXD MartinquaXD merged commit 85cdee7 into main Jun 6, 2024
10 checks passed
@MartinquaXD MartinquaXD deleted the fix-ci-after-foundry-update branch June 6, 2024 07:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants