Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: JIT orders surplus support for cow amm #2699

Merged
merged 30 commits into from
Jul 24, 2024

Conversation

m-lord-renkse
Copy link
Contributor

Description

Tests for the JIT orders surplus support PR: #2682

@m-lord-renkse m-lord-renkse requested a review from a team as a code owner May 7, 2024 13:46
@m-lord-renkse m-lord-renkse changed the base branch from main to 2635/jit-order-surplus-for-cow-amm May 7, 2024 13:46
@m-lord-renkse m-lord-renkse marked this pull request as draft May 7, 2024 13:47
@m-lord-renkse m-lord-renkse force-pushed the 2635/jit-order-surplus-for-cow-amm branch from da53807 to a7097a9 Compare May 7, 2024 13:53
@m-lord-renkse m-lord-renkse force-pushed the 2635/test-jit-order-surplus-for-cow-amm branch 3 times, most recently from 4dc69a6 to 6fc6914 Compare May 7, 2024 14:17
@m-lord-renkse m-lord-renkse marked this pull request as ready for review May 7, 2024 14:18
@m-lord-renkse m-lord-renkse force-pushed the 2635/jit-order-surplus-for-cow-amm branch from a7097a9 to fb91bfd Compare May 8, 2024 07:59
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes in this PR (1k lines) and most of them are not in the test module. Can you adjust the PR description using the standard template to reflect what's happening here?

@m-lord-renkse m-lord-renkse force-pushed the 2635/jit-order-surplus-for-cow-amm branch 2 times, most recently from 7d62114 to 4d53879 Compare May 8, 2024 09:05
@m-lord-renkse m-lord-renkse force-pushed the 2635/test-jit-order-surplus-for-cow-amm branch 2 times, most recently from 5189d9f to 07bcb47 Compare May 8, 2024 11:03
@m-lord-renkse m-lord-renkse requested a review from fleupold May 8, 2024 11:05
@m-lord-renkse
Copy link
Contributor Author

There are a lot of changes in this PR (1k lines) and most of them are not in the test module. Can you adjust the PR description using the standard template to reflect what's happening here?

@fleupold you are right. It seems this branch was auto-updated to the target branch (when I pushed to the target branch) and inserted commits from the target PR (This PR is targeted to another PR and not main). I rebased it, it should be fine now 🙏

@m-lord-renkse m-lord-renkse force-pushed the 2635/test-jit-order-surplus-for-cow-amm branch from 07bcb47 to 593c91b Compare May 8, 2024 12:21
@m-lord-renkse m-lord-renkse force-pushed the 2635/jit-order-surplus-for-cow-amm branch 2 times, most recently from ef56f59 to 0bbb938 Compare May 8, 2024 13:14
@m-lord-renkse m-lord-renkse force-pushed the 2635/test-jit-order-surplus-for-cow-amm branch 2 times, most recently from 6014e14 to 1d039d9 Compare May 8, 2024 14:09
@m-lord-renkse m-lord-renkse force-pushed the 2635/jit-order-surplus-for-cow-amm branch 3 times, most recently from 20df656 to cc2d7e6 Compare May 9, 2024 07:56
@m-lord-renkse m-lord-renkse force-pushed the 2635/test-jit-order-surplus-for-cow-amm branch from 1d039d9 to e83c21b Compare May 9, 2024 07:56
@m-lord-renkse m-lord-renkse force-pushed the 2635/jit-order-surplus-for-cow-amm branch from cc2d7e6 to b39093c Compare May 13, 2024 10:00
@m-lord-renkse m-lord-renkse force-pushed the 2635/test-jit-order-surplus-for-cow-amm branch from e83c21b to 89c9b8d Compare May 13, 2024 10:01
Base automatically changed from 2635/jit-order-surplus-for-cow-amm to main May 13, 2024 10:46
@m-lord-renkse
Copy link
Contributor Author

cc @MartinquaXD 🙏 🙏 🙏

Copy link

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

@github-actions github-actions bot added the stale label Jul 19, 2024
@m-lord-renkse m-lord-renkse requested a review from sunce86 July 19, 2024 10:46
@github-actions github-actions bot removed the stale label Jul 20, 2024
@m-lord-renkse m-lord-renkse merged commit 681faa0 into main Jul 24, 2024
10 checks passed
@m-lord-renkse m-lord-renkse deleted the 2635/test-jit-order-surplus-for-cow-amm branch July 24, 2024 09:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants