Update available networks in network_name #2130
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We get the name of the current network from a list of networks based on chain id and network id.
The list is updated so that Sepolia is also included.
Changes
Updated command to generate the match list.
This is done because the current command only takes the first word in the network name. So for example mainnet would be "Ethereum" instead of "Ethereum Mainnet".
I also sorted the output, so that in the future the diff will be more meaningful.
Ethereum / Mainnet
becomesEthereum Mainnet
(Note that it had more than one word because it was manually changed before)Ethereum / Goerli
becomesGoerli
.xDAI
becomesGnosis
I'm not sure which effects this change is going to have, this value isn't directly needed by the services afaict. The name is used when storing instances, for example, so other parties might rely on it.
Added an ignored test to confirm that the test works.
How to test
New ignored test.