Instrument Solver Engine #2129
Instrument Solver Engine #2129
Conversation
| prometheus = { workspace = true } | ||
| prometheus-metric-storage = { workspace = true } |
There was a problem hiding this comment.
My plan didn't pan out entirely. 🙁
Maybe we can reexport the types we need from those crates in the observe crate as well in another PR. Then observe should be the only crate that directly depends on them.
There was a problem hiding this comment.
I'm not able to get this to compile. The proc macro that generates the Metrics struct requires prometheus_metric_storage so even with re-exports I'm getting
error[E0433]: failed to resolve: use of undeclared crate or module
prometheus_metric_storage
--> crates/solvers/src/infra/metrics.rs:7:24
|
7 | #[derive(Debug, Clone, metrics::MetricStorage)]
| ^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or moduleprometheus_metric_storage
|
= note: this error originates in the derive macrometrics::MetricStorage(in Nightly builds, run with -Z macro-backtrace for more info)
There was a problem hiding this comment.
Feel free to merge the PR without this. It would just be a nice clean up that can happen at any time and should not delay proper metrics on the solvers crate.
That being said I remember exporting macros requiring a specific macro on top of it and reexporting a macro might be even more magical. 😄 🤷♂️
…vices into instrument_solver_engine
Description
Solver engines are currently not exposing any metrics. This PR changes that.
Changes
How to test
Run everything locally and visit http://localhost:7872/metrics
Once merged, this will require an infra change to start scraping metrics in prometheus.
Related Issues
Fixes #1239