Filter in-flight orders #2123
Merged
Filter in-flight orders #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
reviewed
Dec 5, 2023
| @@ -54,6 +55,7 @@ pub struct RunLoop { | |||
| pub score_cap: U256, | |||
| pub max_settlement_transaction_wait: Duration, | |||
| pub solve_deadline: Duration, | |||
| pub in_flight_orders: Arc<Mutex<InFlightOrders>>, | |||
There was a problem hiding this comment.
Why do we need synchronisation here?
There was a problem hiding this comment.
Because we populate the data in a method that takes a shared reference to self.
| /// to fill an order a second time. | ||
| async fn remove_in_flight_orders(&self, mut auction: Auction) -> Auction { | ||
| let prev_settlement = self.in_flight_orders.lock().unwrap().tx_hash; | ||
| let tx_receipt = self.web3.eth().transaction_receipt(prev_settlement).await; |
There was a problem hiding this comment.
What happens if in the first iteration the tx_hash is initialized with Default::default()?
There was a problem hiding this comment.
Then transaction_receipt() would try to find the block that contains tx_hash 0x000... which does not exist so we fallback to assuming the previous auction was settled in block u64::MAX so we discard all in-flight orders we have at the time (which are 0 due to Default::default()).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although the
autopilotcurrently waits until thedriverreports that the settlement was mined the auction of the next run loop might not yet be aware that the orders of the previous settlement were solved.If a solver then tries to solve those orders again it will run into simulation failures.
Changes
We now filter out in-flight orders from the auction if it was built before the block where the in-flight orders were settled.