Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solvers Crate Instrumentation #1239

Closed
nlordell opened this issue Feb 20, 2023 · 2 comments · Fixed by #2129
Closed

solvers Crate Instrumentation #1239

nlordell opened this issue Feb 20, 2023 · 2 comments · Fixed by #2129
Assignees
@fleupold
Labels
E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details

Comments

@nlordell
Copy link
Contributor

It is very much lacking, and we should do a "make this easy to debug" pass on the crate.
@nlordell nlordell mentioned this issue Feb 20, 2023
Merged
@sunce86 sunce86 added the E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details label Oct 16, 2023
@fleupold
Copy link
Contributor

fleupold commented Dec 4, 2023

@harisang suggested to store metrics on how much time each solver receives to solve.

Another metric that would be interesting in the context of dex solvers is how often they fail due to API rate limits or the like.

@fleupold fleupold self-assigned this Dec 6, 2023
@fleupold
Copy link
Contributor

fleupold commented Dec 6, 2023

Rate limits are captured by the already existing rate_limiter_requests_dropped metric

@fleupold fleupold mentioned this issue Dec 6, 2023
Merged
4 tasks
fleupold added a commit that referenced this issue Dec 8, 2023
@fleupold
Instrument Solver Engine (#2129)
03ed19b 
# Description
Solver engines are currently not exposing any metrics. This PR changes
that.

# Changes
- [ ] Collect histogram of initial time_limit when requests come in
- [ ] Collect histogram of remaining time when requests are done
- [ ] Collect number of proposed solutions
- [ ] Collect failure reasons

## How to test
Run everything locally and visit http://localhost:7872/metrics

Once merged, this will require an infra change to start scraping metrics
in prometheus.

## Related Issues

Fixes #1239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fleupold fleupold

Labels
E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Instrument Solver Engine cowprotocol/services
3 participants
@fleupold @nlordell @sunce86