Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: devcontainers #36

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat: devcontainers #36

merged 5 commits into from
Nov 28, 2023

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Nov 28, 2023

Description

To edit the docs using webcontainers, it is not possible to use git submodules (they aren't supported). It is important to ensure that the methodology for editing be the same on VS Code on a developer's machine, as compared to that when editing via webcontainers.

Changes

  • Remove git submodules
  • Use JS scripts within package.json to pull the repositories and trim the .git history folder
  • Add a devcontainer for ensuring consistent development environments
  • Add nvmrc to ensure consistent node versions in devcontainers

@mfw78 mfw78 added the E:2.1: Documentation and Tutorials https://github.com/cowprotocol/pm/issues/10 label Nov 28, 2023
@mfw78 mfw78 self-assigned this Nov 28, 2023
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 4:45pm

@mfw78 mfw78 merged commit 3b529e7 into main Nov 28, 2023
3 checks passed
@mfw78 mfw78 deleted the devcontainer branch November 28, 2023 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E:2.1: Documentation and Tutorials https://github.com/cowprotocol/pm/issues/10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant