Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional-benefits.md #311

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update additional-benefits.md #311

wants to merge 8 commits into from

Conversation

gogonimago
Copy link
Contributor

Description

Changes

  • ...
  • ...

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 24, 2024 7:40am

Copy link

github-actions bot commented Feb 3, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should avoid use of GPv2

- Support for tapping straight into exotic tokens as solvers abstract away intermediate steps like depositing, minting, and staking
- Tighter spreads from private market makers thanks to fast settlement of off-chain orders
- Increased gas efficiency as all trades are credited directly to user accounts without withdrawals or deposits into an exchange contract
- Increased security as funds can only be transferred if a trader has approved the GPv2 contract and signed an order to sell the given token for another
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest either refer directly to the contract, or remove GPv2 and generalise it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed GPv2

Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

Copy link
Contributor Author

@gogonimago gogonimago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore/delete this commit. It was overwritten in the next one

*In reference to the second to last commit da69476

@@ -4,10 +4,23 @@ sidebar_position: 4

# Additional benefits

CoW Protocol's [intent-based trading model](../introduction/intents) provides a number of benefits, including support for expressing any intent, MEV protection, and price improvement. There are also a handful of additional benefits unique to CoW Protocol thanks to its specific architecture:
CoW Protocol's [intent-based trading model](https://docs.cow.fi/cow-protocol/concepts/introduction/intents) and [batch auctions mechanism](https://docs.cow.fi/cow-protocol/concepts/introduction/batch-auctions) come together to provide a number of benefits, including support for expressing any intent, MEV protection, and price improvement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use absolute links for this as this is fragile (if moving domain etc, this will break in the new domain, etc).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the relative links were broken, that's why I changed them to absolute links.

I don't understand how the relative link architecture is supposed to work and why they didn't work on this page but seemingly work on other pages.

Can you help me understand how I'm supposed to format links?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to just chop off the "https://docs.cow.fi" and use from the base href, ie. /cow-proocol/concepts/introduction/intents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I just did this but when I click on them in preview I get a github error. This is originally why I used absolute links also, wondering if it works on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants