update missing prices script #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentrexha
reviewed
Sep 26, 2022
gentrexha
approved these changes
Oct 19, 2022
Comment on lines
+130
to
+139
| if token["address"].lower() in coins: | ||
| paprika_data = coins[token["address"].lower()] | ||
| dune_row = ( | ||
| str(paprika_data["id"]), | ||
| "ethereum", | ||
| str(paprika_data["symbol"]), | ||
| str(paprika_data["address"].lower()), | ||
| int(token["decimals"]), | ||
| ) | ||
| res.append(dune_row) |
There was a problem hiding this comment.
Also for the future we might wanna look into https://marshmallow.readthedocs.io/en/stable/ for easier object serialization/deserialization . What's your take on that?
There was a problem hiding this comment.
Yes I would very much like to do that.
There was a problem hiding this comment.
I am just not so sure how well it will jive with the Ethereum Types. I have been having quite some difficulty with that lately.
There was a problem hiding this comment.
Awesome! We should definitely give it a go and see how we can work with it.
There was a problem hiding this comment.
I will create an issue for this and link it to the TODO about removing Any above.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to generate: duneanalytics/spellbook#1639
Note that it requires having downloaded the query results of https://dune.com/queries/1317238 and saving them to "out/missing-token-prices.csv".
Note this is a total hack and could easily be cleaned up (with types instead of dicts).
Test Plan