Change announcement banner source to separate repository #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
reviewed
May 4, 2023
alfetopito
reviewed
May 4, 2023
alfetopito
approved these changes
May 4, 2023
shoom3301
approved these changes
May 4, 2023
|
Working in dev (Goerli only). Not sure what the best timeline to merge this is to keep config drift between barn and prod small.
|
anxolin
approved these changes
May 5, 2023
There was a problem hiding this comment.
Working in dev (Goerli only). Not sure what the best timeline to merge this is to keep config drift between barn and prod small.
It's fine to merge any time. This will go to develop. And next week, hopefully, we will close a version. It will be in the next release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on cowprotocol/cowswap-banner#1
This PR changes the source from which we fetch announcements from the config branch in this repo to a separate repository to which we can give the entire team unrestricted access. This will allow us to act quickly and without occupying technical ressources (which will be busy with debugging) in the case there is an outage or issue with the product.
As a follow up I will I update the instructions in https://www.notion.so/cownation/Set-Announcement-Warning-Banner-Message-e7f71d85a1d34d29ba8a41c8c1acceba and remove the files in the configuration branch after this change is released into production (ideally we release it relatively quickly after merging this PR to reduce the amount of configuration drift between prod and barn and not having to change the announcement in two places)
To Test
Background
https://cowservices.slack.com/archives/C036G0J90BU/p1682353087323919