Goodbye, bad whitespace #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase? |
|
Wooo, this is an old one. I'll give it a go :) |
rthbound
force-pushed
the
removes_trailing_whitespace_and_hard_tabs
branch
from
c80c5d9 to
7a5b5d9
Compare
rthbound
force-pushed
the
removes_trailing_whitespace_and_hard_tabs
branch
from
7a5b5d9 to
88a3874
Compare
|
@mathieujobin, rebase finished. Cheers! |
mathieujobin
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will remove hard tabs and trailing whitespace from lines throughout the codebase.
In order to reveal offending lines, I used a version of bundler's quality_spec. The spec breaks with more recent versions of rspec, which is the only reason I haven't included the spec itself with this PR.