Drop clients from proxy_worker, not proxy_conn #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous refactor moved the authorization process from the proxy_conn to the proxy_worker, but did not introduce any mechanism to drop an in-progress authorization before a client connection was assigned to an available proxy_conn for normal use. Because ownership of the client connection was also moved to the proxy_worker, it's safe to initiate the connection dropping process from the proxy_worker instead of the proxy_conn, which will cover the in-progress authorization case as well.
This was previously done with a borrowed reference to the client connection here:
openelp/src/proxy_conn.c
Lines 850 to 860 in 11fde32