-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change from u8 to u16 conversion to prevent key-value pairs length overflow #251
Conversation
for more info, NixOS/nixpkgs@88187b4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left some comments. Also, you should also make the same changes in the sp1 programs which read these inputs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 12 12
Lines 572 572
=======================================
Hits 569 569
Misses 3 3 ☔ View full report in Codecov by Sentry. |
I've updated the sp1 program, thanks you for the contribution |
Description
closes: #250
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.