Skip to content

Commit

Permalink
fix(ics20): PrefixedDenom parsing (#1178)
Browse files Browse the repository at this point in the history
* add failing test

* add TracePath::new

* imp PrefixedDenom parsing

* add validate_named_u64_index

* validate_named_u64_index in channel and connection validation

* add tests for validate_named_u64_index

* update PrefixDenom parsing tests

* update accepted cases in ibc-go

* update accepted cases

* add test cases from ibc-go

* use valid connection id

* failing doc tests

* use existing constants

* changelog entry

* refactor tests

* apply suggestions from code review

Co-authored-by: Sean Chen <[email protected]>
Co-authored-by: Farhad Shabani <[email protected]>
Signed-off-by: Rano | Ranadeep <[email protected]>

* add comment for PrefixedDenom::from_str

* rm TracePath::new

* collect the same tests

* test parsed PrefixedDenom string repr

* test trace order

* more tests

* update tests

* rm redundant error variant

* refactor tests

* update doc string

* add comment on virtual split_twice

* update doc str

* add TracePrefix::strip and TracePath::trim

* add whitespace cases

* refactor tests

* spelling

* parse over from_str

* nit

* apply suggestions from code review

Co-authored-by: Sean Chen <[email protected]>
Signed-off-by: Rano | Ranadeep <[email protected]>

* add failing test

* fix TracePath::from_str

* fix parsing

* fix test

* add ibc-app-transfer-types dep

* rm reusable code

* update impls

* update tests

* accepted class ids

* refactor tests

* update changelog entry

* opt trace prefix and path parsing

* add new tests

* Update changelog entry

* fix trace-prefix index order

---------

Signed-off-by: Rano | Ranadeep <[email protected]>
Co-authored-by: Sean Chen <[email protected]>
Co-authored-by: Farhad Shabani <[email protected]>
  • Loading branch information
3 people authored Apr 26, 2024
1 parent cdf6cf5 commit e5c626f
Show file tree
Hide file tree
Showing 9 changed files with 469 additions and 341 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- [ibc-app-transfer] Bring `PrefixedDenom` parsing up to parity with `ibc-go`.
([\#1177](https://github.com/cosmos/ibc-rs/issues/1177))
- [ibc-app-nft-transfer] Reuse `TracePrefix` and `TracePath` from
`ibc-app-transfer-types` when parsing `PrefixedClassId`.
([\#1178](https://github.com/cosmos/ibc-rs/pull/1178))
Loading

0 comments on commit e5c626f

Please sign in to comment.