Fixing a few PHP Warnings #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hp on line 37 by verifying if the key exist
…114 by verifying if is null
…n line 323 by verifying if the key exist
… of the key 'date'.'modified' and returning 0 if nothing is found
splitbrain
requested changes
Jan 23, 2025
| @@ -34,7 +34,7 @@ function handle_start(Doku_Event $event) { | |||
| } | |||
|
|
|||
| global $_GET; | |||
| if($_GET['force_rev']) { | |||
| if(isset($_GET['force_rev']) && $_GET['force_rev']) { | |||
There was a problem hiding this comment.
The proper fix would be to the $INPUT class here
There was a problem hiding this comment.
Which essentially means in the DokuWiki Core right? So unnecessary here.
| } | ||
| if (isset($meta['date']['modified'])) { | ||
| return $meta['date']['modified']; | ||
| } |
There was a problem hiding this comment.
This could be simplified using the ?? operator
| @@ -320,7 +325,7 @@ function isHiddenForUser($id = null) { | |||
| return auth_quickaclcheck($id) < AUTH_EDIT; | |||
| } | |||
|
|
|||
| if (!$_SERVER['REMOTE_USER']) { | |||
| if (!isset($_SERVER['REMOTE_USER'])) { | |||
There was a problem hiding this comment.
Again a case for $INPUT->server
There was a problem hiding this comment.
To be fair, I didn't know about the Input Class, I'll have to review the class then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing some quick fix on some of the PHP Warnings I have in my server log.