Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class info to all data #688

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

Carifio24
Copy link
Member

@Carifio24 Carifio24 commented Nov 19, 2024

This PR adds the student's class info to the "all data" datasets:

  • Calculate the age value from the class's measurements and add it to the "all class summaries" dataset
  • Add all of the individual measurements from the class to the "all measurements" dataset

This builds off of #687 and addresses a couple of the points in #660.

@Carifio24 Carifio24 mentioned this pull request Nov 19, 2024
20 tasks
@patudom
Copy link
Contributor

patudom commented Dec 13, 2024

@Carifio24, when I run this PR, "my class's" data set appears blank in the slider viewer. Does it show up for you? (Stage 5, marker 'cla_res1c1`).

Screen.Recording.2024-12-13.at.2.02.43.PM.mov

@Carifio24
Copy link
Member Author

Which class ID is this for?

@patudom
Copy link
Contributor

patudom commented Dec 13, 2024

215 (the class that has the demo2024 code).

@Carifio24
Copy link
Member Author

@patudom Does my most recent commit fix the issue for you?

@patudom
Copy link
Contributor

patudom commented Dec 13, 2024

Yes, thank you, Jon!

@patudom patudom merged commit 00d7143 into cosmicds:main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants