Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display CSalienInfoBox during battle screen #25

Closed
wants to merge 1 commit into from
Closed

display CSalienInfoBox during battle screen #25

wants to merge 1 commit into from

Conversation

Gummibeer
Copy link
Contributor

adds: #19

@Gummibeer
Copy link
Contributor Author

It adds the info screen everytime the function runs - have to do it just once per round.

@Wiethoofd
Copy link

Move it inside the setTimeout in the joinZone function where it sets the gameCheck intervalFunc, then it loads the planet and base and only inserts the info box once.

@farooo
Copy link

farooo commented Jun 22, 2018

Yes as @Wiethoofd says. I tested @Gummibeer code and i got big frame drops in the game. I started a pull request where i output the info into the console. See #32

@coryshaw1
Copy link
Owner

coryshaw1 commented Jun 25, 2018

Closed by 1670382

This only tries to add the profile box once at the beginning of a round, and if one already exists, the existing box is destroyed to make room for the new box. Keeping memory down.

@coryshaw1 coryshaw1 closed this Jun 25, 2018
@Gummibeer Gummibeer deleted the patch-2 branch June 25, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants