Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added data type for the reference image produced by the latest neurop… #901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grg2rsr
Copy link
Collaborator

@grg2rsr grg2rsr commented Jan 10, 2025

…hotometrics software version

@grg2rsr grg2rsr requested a review from k1o0 January 10, 2025 16:38
Copy link
Collaborator

@k1o0 k1o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underscore is invalid here. A dataset that starts with an underscore must have an enclosing underscore. It indicates a 'namespace' which is added when a dataset is considered non-standard. For example _ibl_trials means that the trials object is part of the ibl namespace and only relevant to IBL experiments. It's a way to acknowledge that the dataset isn't intended to be broadly adopted. Trials tables vary a lot by task protocol, whereas spikes.times (which has no namespace) is a community standard dataset.

We can discuss at the DAWG but I'd suggest making this a non-standard dataset type (either ibl or np for neurophotometrics).

If the dataset type name is . then you can leave the filename pattern as null and it will check that the registered dataset's object.attribute name part matches the dataset type name. If you want the namespace to be essential (and explicit) you should add a filename pattern, e.g. _np_fpData.regionImage.* or _*_fpData.regionImage.*, otherwise any dataset with or without the namespace will be registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants