ModuleMan Refactoring and Improvements #8
+1,188
−1,355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and shouldn't be exposed Modules are (currently) either loaded or not (if disabled via mod manager) Can't allow some bullshit module that is either outside the Data/Mods directories or hidden inside another module to be loaded like this and possibly break all the shit
… so much pointless code
…directly from the modules
…n IDs when loading
…odule (followup to 895556c)
…Module::CreateOnDiskAsUserdata Don't need this exposed to all the things, ModuleMan mans the modules Abort if the userdata modules failed to load so this doesn't screw us at some point later
… load Also check that it's not userdata
…check the module's type
…on demand Demand is literally in one place when texturizing terrain Fixes my stack overflow lel AAAAAAAAAAAAAAAAAAAAAAAAA
… should ever do that anyways... hmm)
|
Before merging this I want to potentially look at making some of the changes deprecated instead of entirely breaking (or at least adding support to Trez's tool to automatically update this), and also investigate why GetOfficialModuleCount was removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors a buncha stuff, simplifies PresetMan by moving stuff to a new ModuleMan. Allows runtime enabling+disabling of mods, though likely needs a little extra work.
MaximDude's work