Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update branch before working #412

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0a4bf20
try to fix keyboard shortcut on mac
barais Nov 17, 2023
1b13ba9
Merge pull request #390 from correctexam/388-keyboard-short-cut-issue…
barais Nov 17, 2023
96a5aba
fix(latex): fix some commands and doc updated
arnobl Nov 17, 2023
451a883
update comment as a simple texte
barais Nov 18, 2023
c81b95c
reintroduce simple text comment withing the image
barais Nov 18, 2023
f3bed99
Merge pull request #392 from correctexam/388-keyboard-short-cut-issue…
barais Nov 18, 2023
933e256
update color choice
barais Nov 19, 2023
84e18fc
Merge pull request #393 from correctexam/388-keyboard-short-cut-issue…
barais Nov 19, 2023
360b4b8
keep the same order for comments
barais Nov 19, 2023
24fdd5c
Merge pull request #394 from correctexam/388-keyboard-short-cut-issue…
barais Nov 19, 2023
084f8e3
close #391
barais Nov 19, 2023
dc30207
Merge pull request #395 from correctexam/388-keyboard-short-cut-issue…
barais Nov 19, 2023
8d3062d
remove logs
barais Nov 19, 2023
0660843
Merge pull request #396 from correctexam/388-keyboard-short-cut-issue…
barais Nov 19, 2023
b1bddf5
update to allow editing text when creating it in correction view
barais Nov 20, 2023
f29f49a
Merge pull request #398 from correctexam/388-keyboard-short-cut-issue…
barais Nov 20, 2023
0f52182
update comment list when no studentresponse (means response not yet …
barais Nov 21, 2023
c278dc9
Merge pull request #399 from correctexam/388-keyboard-short-cut-issue…
barais Nov 21, 2023
40269e8
update comment
barais Nov 21, 2023
e72c348
Merge pull request #400 from correctexam/388-keyboard-short-cut-issue…
barais Nov 21, 2023
22f091d
close #402
barais Nov 23, 2023
e58e312
update
barais Nov 23, 2023
c031b47
Merge pull request #403 from correctexam/402-feedback-view-add-a-link…
barais Nov 23, 2023
7837d3a
decrease comment size in minimized mode to show more comments in the …
barais Nov 24, 2023
2eae1e7
Merge pull request #404 from correctexam/402-feedback-view-add-a-link…
barais Nov 24, 2023
9b8b785
update layout
barais Nov 24, 2023
8eb7a76
update css
barais Nov 24, 2023
51633bd
Merge pull request #405 from correctexam/402-feedback-view-add-a-link…
barais Nov 24, 2023
8279a3c
update default keyboard shortcut for each comment
barais Nov 25, 2023
7c62a5f
update comment shortcut default
barais Nov 25, 2023
3066167
Merge pull request #409 from correctexam/402-feedback-view-add-a-link…
barais Nov 25, 2023
45966c7
clean comment when changing questionno
barais Nov 25, 2023
a7f2ce8
close #407
barais Nov 26, 2023
2f36166
Merge pull request #410 from correctexam/402-feedback-view-add-a-link…
barais Nov 26, 2023
670b2e8
update block for resultat view
barais Nov 26, 2023
d11668a
Merge pull request #411 from correctexam/402-feedback-view-add-a-link…
barais Nov 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export interface IGradedComment {
grade?: number | null;
questionId?: number;
studentResponses?: IStudentResponse[];
shortcut?: string | string[];
}

export class GradedComment implements IGradedComment {
Expand All @@ -18,7 +19,8 @@ export class GradedComment implements IGradedComment {
public description?: string | null,
public grade?: number | null,
public questionId?: number,
public studentResponses?: IStudentResponse[]
public studentResponses?: IStudentResponse[],
public shortcut?: string | string[],
) {}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export interface ITextComment {
zonegeneratedid?: string | null;
questionId?: number;
studentResponses?: IStudentResponse[];
shortcut?: string | string[];
}

export class TextComment implements ITextComment {
Expand All @@ -16,7 +17,8 @@ export class TextComment implements ITextComment {
public description?: string | null,
public zonegeneratedid?: string | null,
public questionId?: number,
public studentResponses?: IStudentResponse[]
public studentResponses?: IStudentResponse[],
public shortcut?: string | string[],
) {}
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/webapp/app/opencv.worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ async function doPredictionsAsync(p: {
}
console.timeEnd('analysePage');
}
console.error(JSON.stringify(source));
// console.error(JSON.stringify(source));
source.target.postMessage({ msg: p.msg, payload: outputs, uid: p.uid }, opts);
} else {
// TODO
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@
<div class="">
<jhi-fabric-canvas [exam]="exam" [content]="content" [numeroEvent]="numero"></jhi-fabric-canvas>
</div>
<div class="flex flex-column flex-grow-1 top-0 right-0 p-1 m-2">
<button type="submit" (click)="previousState()" class="right-0 p-button-primary" pButton data-cy="entityDetailsBackButton">
<div
class="flex flex-column flex-grow-1 top-0 right-0 p-1 m-2"
style="overflow-y: auto; overflow-x: hidden; max-height: 85vh; position: sticky; top: 0"
>
<button
style="overflow: visible"
type="submit"
(click)="previousState()"
class="right-0 p-button-primary"
pButton
data-cy="entityDetailsBackButton"
>
<fa-icon icon="arrow-left"></fa-icon>&nbsp;<span jhiTranslate="entity.action.back">Back</span>
</button>
<div class="templateForm">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<p-sidebar [position]="'right'" [(visible)]="layoutsidebarVisible">
<p-sidebar
[position]="'right'"
[(visible)]="layoutsidebarVisible"
[blockScroll]="true"
[showCloseIcon]="true"
styleClass="p-0"
appendTo="body"
>
<jhi-create-comments [question]="questions[0]"></jhi-create-comments>
</p-sidebar>

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ <h3 jhiTranslate="scanexam.confirmremove"></h3>
<img src="/content/images/toolbar-images/fill.png" />
</div>-->
</div>
<div class="d-flex flex-wrap mb-5">
<div class="d-flex flex-wrap mb-1">
<div
[title]="'scanexam.erase' | translate"
class="toolbox-item ml-1 mt-1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,15 +262,15 @@ export class AssocierCopiesEtudiantsComponent implements OnInit, AfterViewInit {
this.shortcuts.push(
{
// ArrowRight
key: ['ctrl + right', 'meta + right'],
key: ['ctrl + right', 'cmd + right'],
label: 'Navigation',
description: this.translateService.instant('scanexam.nextstudent'),
command: () => this.nextStudent(),
preventDefault: true,
},
{
// ArrowLeft
key: ['ctrl + left', 'meta + left'],
key: ['ctrl + left', 'cmd + left'],
label: 'Navigation',
description: this.translateService.instant('scanexam.previousstudent'),
command: () => this.previousStudent(),
Expand Down Expand Up @@ -359,9 +359,6 @@ export class AssocierCopiesEtudiantsComponent implements OnInit, AfterViewInit {
);
}

/* console.error(candidateName.map((e: any) => (this.latinise(e)! as string).toLowerCase()));
console.error(candidateFirstName.map((e: any) => (this.latinise(e)! as string)?.toLowerCase()));
console.error(candidateIne.map((e: any) => (this.latinise(e)! as string)?.toLowerCase())); */
let pageNumber = z1?.pageNumber;
if (pageNumber === undefined) {
pageNumber = z2?.pageNumber;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export class ZoneCorrectionHandler {
canvas.on('selection:updated', (e: any) => this.onSelectionUpdated(e as any));
canvas.on('object:moving', (e: any) => this.onObjectMoving(e as any));
canvas.on('object:scaling', (e: any) => this.onObjectScaling(e as any));
canvas.on('object:modified', () => this.onObjectModified());
}

private onCanvasMouseDown(event: { e: Event }) {
Expand All @@ -99,6 +100,11 @@ export class ZoneCorrectionHandler {
this.eventHandler.canvas = this.canvas!;
this.eventHandler.mouseUp();
}
private onObjectModified() {
this.eventHandler.canvas = this.canvas!;
this.eventHandler.objectModified();
}

private onSelectionCreated(e: any) {
this.eventHandler.canvas = this.canvas!;

Expand Down
Loading