Calling IContext::wait() with an empty handle results in `vkDeviceW…

…aitIdle()`
corporateshark · Sep 23, 2024 · f43dd48 · f43dd48
1 parent 27f58a9
commit f43dd48
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lvk/LVK.h b/lvk/LVK.h
@@ -979,7 +979,7 @@ class IContext {
   virtual ICommandBuffer& acquireCommandBuffer() = 0;
 
   virtual SubmitHandle submit(ICommandBuffer& commandBuffer, TextureHandle present = {}) = 0;
-  virtual void wait(SubmitHandle handle) = 0;
+  virtual void wait(SubmitHandle handle) = 0; // waiting on an empty handle results in vkDeviceWaitIdle()
 
   [[nodiscard]] virtual Holder<BufferHandle> createBuffer(const BufferDesc& desc, Result* outResult = nullptr) = 0;
   [[nodiscard]] virtual Holder<SamplerHandle> createSampler(const SamplerStateDesc& desc, Result* outResult = nullptr) = 0;

diff --git a/lvk/vulkan/VulkanClasses.cpp b/lvk/vulkan/VulkanClasses.cpp
@@ -1423,6 +1423,11 @@ const lvk::VulkanImmediateCommands::CommandBufferWrapper& lvk::VulkanImmediateCo
 void lvk::VulkanImmediateCommands::wait(const SubmitHandle handle) {
   LVK_PROFILER_FUNCTION_COLOR(LVK_PROFILER_COLOR_WAIT);
 
+  if (handle.empty()) {
+    vkDeviceWaitIdle(device_);
+    return;
+  }
+
   if (isReady(handle)) {
     return;
   }