fix(world): Items and traits duplication issue on encyclopedia #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
approved these changes
Apr 17, 2024
itinerare
added
bug
|
I'd assume it can occur for most objects in /world, then, it just usually isn't a trouble/they usually aren't in significant enough numbers for the issue to manifest. |
This can ABSOLUTELY occur for most objects in /world - I'm in fact surprised it's not doing it on the masterlist or userlists. I just figured that Currencies, Rarities, Species, Species Categories, Trait Categories, Subtypes and Item Categories are unlikely to hit the same amount. Even if so.. the same fix can be easily applied. |
|
...and so I did. Seems like a good idea. |
AW0005
approved these changes
Apr 18, 2024
itinerare
approved these changes
Apr 18, 2024
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On LKs with high amounts of items/traits, eventually items/traits start duplicating over pages. An item/trait that was halfway page 8 is also at the top of page 9.
And worst of all: When you get to the last page, you definitely have not seen all items/traits. Some of them have just poofed into the ether.
With this ingenious solution I have finally prevented this duplication!
(Note: solution is actually really, really dumb. I can't believe this fixed it.)