Skip to content

Commit

Permalink
[MINOR] Silence compiler warnings (DenseMatrix<const char>)
Browse files Browse the repository at this point in the history
The unmaintained const char specialization of DenseMatrix caused two warnings.
  • Loading branch information
corepointer committed Sep 24, 2024
1 parent f37cf64 commit 000c22f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/runtime/local/datastructures/DenseMatrix.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -404,4 +404,4 @@ template class DenseMatrix<unsigned char>;
template class DenseMatrix<unsigned int>;
template class DenseMatrix<unsigned long>;
template class DenseMatrix<bool>;
template class DenseMatrix<const char *>;
//template class DenseMatrix<const char *>;
2 changes: 2 additions & 0 deletions src/runtime/local/datastructures/ValueTypeUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ template <> const ValueTypeCode ValueTypeUtils::codeFor<uint32_t>;
template <> const ValueTypeCode ValueTypeUtils::codeFor<uint64_t>;
template <> const ValueTypeCode ValueTypeUtils::codeFor<float>;
template <> const ValueTypeCode ValueTypeUtils::codeFor<double>;
// silence compiler warning
template <> const ValueTypeCode ValueTypeUtils::codeFor<const char*>;

template <> const std::string ValueTypeUtils::cppNameFor<int8_t>;
template <> const std::string ValueTypeUtils::cppNameFor<int32_t>;
Expand Down

0 comments on commit 000c22f

Please sign in to comment.