Skip to content

Commit

Permalink
Fix for dataset and model variables Errors when downloading fairseq m…
Browse files Browse the repository at this point in the history
…odels

in the original implementation, the dataset and model variables were causing errors due to uninitialized in the TTS fairseq models.

Changes Made:

Introduced a line to split model_name into model_attributes based on the '/' delimiter. This ensures that the different components of the model name (language, dataset, model) can be separately and accurately accessed.
Added lines to explicitly extract lang, dataset, and model from model_attributes using their respective indices. This change makes the code more robust and clear, as it directly links the variables to their sources:
lang is now set to the second component (model_attributes[1]),
dataset to the third (model_attributes[2]),
model to the fourth (model_attributes[3]).
  • Loading branch information
Mahmoud-ghareeb authored Apr 17, 2024
1 parent dbf1a08 commit dbe9cf8
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion TTS/utils/manage.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,9 @@ def set_model_url(model_item: Dict):
def _set_model_item(self, model_name):
# fetch model info from the dict
if "fairseq" in model_name:
model_attributes = model_name.split("/")
model_type = "tts_models"
lang = model_name.split("/")[1]
lang = model_attributes[1]
model_item = {
"model_type": "tts_models",
"license": "CC BY-NC 4.0",
Expand All @@ -270,6 +271,9 @@ def _set_model_item(self, model_name):
"description": "this model is released by Meta under Fairseq repo. Visit https://github.com/facebookresearch/fairseq/tree/main/examples/mms for more info.",
}
model_item["model_name"] = model_name
dataset = model_attributes[2]
model = model_attributes[3]

elif "xtts" in model_name and len(model_name.split("/")) != 4:
# loading xtts models with only model name (e.g. xtts_v2.0.2)
# check model name has the version number with regex
Expand Down

0 comments on commit dbe9cf8

Please sign in to comment.