add CODEOWNERS for stdpp and iris package directories #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Robbert is on vacation for a few weeks, not sure if he will reply. He doesn't have much oapm experience either. I named him just to make sure that if in doubt, we are not blocked on me (e.g. when I am traveling). But you said anyway that after a few days of silence from my side you'd go ahead with merging things, so if we follow that protocol, maybe having one Iris team member listed is enough? |
|
@RalfJung OK, then let's say it's just you in CODEOWNERS for now. |
palmskog
force-pushed
the
codeowners-iris-stdpp
branch
from
3faa85a to
edfaeb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #2256, ping @RalfJung.
@robbertkrebbers can you please confirm you also want to be reviewer/approver for these Iris and Stdpp packages? Then, we will give you write access to the repo.