Reports: Download all #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new update allows the administrator to download a zip containing all the current CSV documents. Issue #596.
if you try to download the zip repeatedly, this error may appear, so now the algorithm retries it if it happens. It also make sure to close Tempfile.
All the new methods that I implemented are now covered with the exception of the rescue block. Issue #596
…admins to update this branch
franpb14
commented
Apr 20, 2021
markets
approved these changes
Apr 24, 2021
There was a problem hiding this comment.
@franpb14 I pushed a couple of commits (most interesting one is 1914af8) with some refactoring. Basically to make pull collections more DRY. The rest seems fine to me ✅ 👍🏼
@sseerrggii ready for testing 👀
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve this I have done as described in the step #596 (using rubyzip and calling the reports). A simple demonstration of how it works is given below.
