Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cz-commitlint): add emoji to title #3618

Closed
wants to merge 1 commit into from
Closed

feat(cz-commitlint): add emoji to title #3618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions @commitlint/cz-commitlint/src/services/getRuleQuestionConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,15 @@ export default function (rulePrefix: RuleField): QuestionConfig | null {
const longest = Math.max(
...enumRuleList.map((enumName) => enumName.length)
);
// TODO emoji + title
enumList = enumRuleList
.sort((a, b) => enumNames.indexOf(a) - enumNames.indexOf(b))
.map((enumName) => {
const enumDescription = enumDescriptions[enumName]?.description;
if (enumDescription) {
const emoji = enumDescriptions[enumName]?.emoji;
const prefix = emoji ? emoji + ' ' : '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the different number of characters in the composition of Emoji, it is necessary to determine the longest one and perform space alignment processing.

image

return {
name: `${enumName}:`.padEnd(longest + 4) + enumDescription,
name: `${prefix}${enumName}:`.padEnd(longest + 4) + enumDescription,
value: enumName,
short: enumName,
};
Expand Down