feat(load): resolve plugins correctly if provided as relative or absolute path

[armano2]

Description

fixes #932

Motivation and Context

Usage examples

How Has This Been Tested?

Unit tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[armano2]

https://nodejs.org/api/path.html#path_path_isabsolute_path

For example, on POSIX:

path.isAbsolute('/foo/bar'); // true
path.isAbsolute('/baz/..');  // true
path.isAbsolute('qux/');     // false
path.isAbsolute('.');        // false

On Windows:

path.isAbsolute('//server');    // true
path.isAbsolute('\\\\server');  // true
path.isAbsolute('C:/foo/..');   // true
path.isAbsolute('C:\\foo\\..'); // true
path.isAbsolute('bar\\baz');    // false
path.isAbsolute('bar/baz');     // false
path.isAbsolute('.');           // false

[armano2]

this could be done in form of regexp

/^\.{1,2}(\/|\\)/g

https://regexr.com/5k20p

[escapedcat]

True, personally I like the readability of the current code as long as won't grow to more cases.

[armano2]

I'm no longer sure about this change, user should just require('./some/path') to load plugin as local, and this is already supported

[escapedcat]

Hm, as you mentioned this works:

{
  plugins: [require('./dir/my-custom-plugin.js')],
}

I think it's fine to point out in the docs to use this and not paths directly in the array. Seems cleaner to me.

[armano2]

ok, than i'm going to close this PR, as those changes seem less stable compared to providing functions dirrectly