-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Percival #255
Add Percival #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocots nice to have added Percival in the doc 👍🏽
docs/src/tutorial-nlp.md
Outdated
@@ -48,22 +59,28 @@ You can extract this raw NLP problem with the [`get_nlp`](@ref) method. | |||
nlp = get_nlp(docp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocots this syntax has been changed in CTDirect 0.10 (and will be in OptimalControl next release) ; @PierreMartinon do you confirm it should be docp, nlp = direct_transcription(...)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. @PierreMartinon has already changed this file. We will have to merge both updates.
Yes but it does not seem to work well. I have used the solution from ipopt as initial guess but no improvement compared to default initial guess. |
@ocots maybe we merge this one first then update the 0.10.0 one ? |
As you want. I can also update it later. |
Done. All yours :D |
@ocots are you waiting to solve the conflicts below to release |
@jbcaillau No I am just waiting to dry 🏖 |
@ocots while you're drying 🙂 #251 (comment) |
@PierreMartinon @ocots guys, can you please resolve and merge? I'm stuck in #257 seemingly because of this: @ Documenter ~/.julia/packages/Documenter/qoyeC/src/utilities/utilities.jl:46
┌ Error: failed to run `@example` block in src/tutorial-nlp.md:39-42
│ ```@example main
│ docp, nlp = direct_transcription(ocp)
│ nothing # hide
│ ```
│ exception =
│ MethodError: no method matching iterate(::DOCP) |
Ok I do it asap. |
I fixed the tutorial conflict (2 calls to get_nlp removed) |
Could be nice. Have you seen that it does not perform well on the example? |
Not yet, I'll try the small benchmark series |
No description provided.