time! is revised

[ocots]

First merge #147 then this one.

[ocots]

I have revised time!. There is only one method. For the unitary test, I have added a file test/utils.jl with auxiliary __time! methods to keep the tests as there were.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.05%. Comparing base (f7f23cc) to head (ec9e3b1).
Report is 57 commits behind head on main.

❗ Current head ec9e3b1 differs from pull request most recent head f6e69d4

Please upload reports for the commit f6e69d4 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   81.52%   80.05%   -1.48%     
==========================================
  Files          16       17       +1     
  Lines        1873     1955      +82     
==========================================
+ Hits         1527     1565      +38     
- Misses        346      390      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jbcaillau]

@ocots at some point, we should switch to Variable / NonVariable instead of Fixed / NonFixed (maybe keeping the old syntax). I plead guilty on this 🙁

[jbcaillau]

@ocots now Index is only used to store internally (= a user will not see it, even with the functional API) the index of the variable associated with free initial / final time 👍🏽

And nice consistency checks!

[jbcaillau]

@ocots 👍🏽

[jbcaillau]

@ocots more or less resolved conflicts between __constraint! from main and _time! from this branch, but still need to correct some tests (not passing). having a look at it, then merging 🤞🏾

[jbcaillau]

@ocots will do it tonight / tomorrow

still need to correct some tests (not passing). having a look at it, then merging 🤞🏾

[ocots]

I am watching you 🥸

[ocots]

So?

[ocots]

I have updated the tests.

[jbcaillau]

@ocots thanks 👍🏽 for updating the tests: couldn't find time to do it yesterday 🙏🏽