Skip to content

Commit

Permalink
chore: removed redundant attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexpop-zengenti
alexpop-zengenti committed Apr 11, 2024
1 parent 815c50f commit 1ed6ea7
Show file tree
Hide file tree
Showing 28 changed files with 6 additions and 160 deletions.
8 changes: 0 additions & 8 deletions ....Contensis.RequestHandler.LocalDevelopment.Unit.Specs/Models/Headers/CreateHeaderSpecs.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ public class CreateFromAnIEnumerableDictionary
{
private Domain.ValueTypes.Headers _result;

[When]
public void WhenHeadersAreCreatedFromAnIEnumerableDictionary()
{
_result = new Domain.ValueTypes.Headers(
Expand All @@ -32,7 +31,6 @@ public void WhenHeadersAreCreatedFromAnIEnumerableDictionary()
});
}

[Then]
public void ThenTheValuesAreCorrectlySet()
{
Assert.That(_result.Values.Count, Is.EqualTo(2));
Expand All @@ -51,7 +49,6 @@ public class CreateFromASingleValueDictionary
{
private Domain.ValueTypes.Headers _result;

[When]
public void WhenHeadersAreCreatedFromASingleValueDictionary()
{
_result = new Domain.ValueTypes.Headers(
Expand All @@ -66,7 +63,6 @@ public void WhenHeadersAreCreatedFromASingleValueDictionary()
});
}

[Then]
public void ThenTheValuesAreCorrectlySet()
{
Assert.That(_result.Values.Count, Is.EqualTo(2));
Expand All @@ -85,7 +81,6 @@ public class CreateFromAnIHeaderDictionary
{
private Domain.ValueTypes.Headers _result;

[When]
public void WhenHeadersAreCreatedFromAnIHeaderDictionary()
{
_result = new Domain.ValueTypes.Headers(
Expand All @@ -101,7 +96,6 @@ public void WhenHeadersAreCreatedFromAnIHeaderDictionary()
}));
}

[Then]
public void ThenTheValuesAreCorrectlySet()
{
Assert.That(_result.Values.Count, Is.EqualTo(2));
Expand All @@ -120,7 +114,6 @@ public class CreateFromHttpResponseHeaders
{
private Domain.ValueTypes.Headers _result;

[When]
public void WhenHeadersAreCreatedFromHttpResponseHeaders()
{
var response = new HttpResponseMessage();
Expand All @@ -130,7 +123,6 @@ public void WhenHeadersAreCreatedFromHttpResponseHeaders()
_result = new Domain.ValueTypes.Headers(response.Headers);
}

[Then]
public void ThenTheValuesAreCorrectlySet()
{
Assert.That(_result.Values.Count, Is.EqualTo(2));
Expand Down
9 changes: 0 additions & 9 deletions ...i.Contensis.RequestHandler.LocalDevelopment.Unit.Specs/Models/Headers/HeaderMergeSpecs.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ public class MatchingHeadersExists
private readonly Domain.ValueTypes.Headers _sut = new();
private Domain.ValueTypes.Headers _result;

[Given]
public void GivenHeadersExist()
{
_sut.Add(
Expand All @@ -27,7 +26,6 @@ public void GivenHeadersExist()
});
}

[When]
public void WhenAMatchingHeaderValueIsMerged()
{
var toMerge = new Domain.ValueTypes.Headers();
Expand All @@ -41,7 +39,6 @@ public void WhenAMatchingHeaderValueIsMerged()
_result = _sut.Merge(toMerge);
}

[Then]
public void ThenTheMatchingHeaderValueIsOverridden()
{
Assert.That(_result.Values.Count, Is.EqualTo(2));
Expand All @@ -61,7 +58,6 @@ public class NoMatchingHeadersExist
private readonly Domain.ValueTypes.Headers _sut = new();
private Domain.ValueTypes.Headers _result;

[Given]
public void GivenHeadersExist()
{
_sut.Add(
Expand All @@ -78,7 +74,6 @@ public void GivenHeadersExist()
});
}

[When]
public void WhenAHeaderValueIsMergedThatDoesNotAlreadyExist()
{
var toMerge = new Domain.ValueTypes.Headers();
Expand All @@ -92,7 +87,6 @@ public void WhenAHeaderValueIsMergedThatDoesNotAlreadyExist()
_result = _sut.Merge(toMerge);
}

[Then]
public void ThenTheNewHeaderValueIsAdded()
{
Assert.That(_result.Values.Count, Is.EqualTo(3));
Expand All @@ -115,7 +109,6 @@ public class CaseInsensitiveKey
private readonly Domain.ValueTypes.Headers _sut = new();
private Domain.ValueTypes.Headers _result;

[Given]
public void GivenAHeadersExistsThatIsHandledCaseInsensitively()
{
_sut.Add(
Expand All @@ -126,7 +119,6 @@ public void GivenAHeadersExistsThatIsHandledCaseInsensitively()
});
}

[When]
public void WhenAHeaderWithTheSameNameButDifferentCaseIsMerged()
{
var toMerge = new Domain.ValueTypes.Headers();
Expand All @@ -140,7 +132,6 @@ public void WhenAHeaderWithTheSameNameButDifferentCaseIsMerged()
_result = _sut.Merge(toMerge);
}

[Then]
public void ThenTheHeaderValueIsOverriden()
{
Assert.That(_result.Values.Count, Is.EqualTo(1));
Expand Down
6 changes: 0 additions & 6 deletions tests/Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs/Models/MetricsSpecs.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,18 @@ public class HasMetrics
private readonly Metrics _sut = new();
private string _result;

[Given]
public void GivenThereAreSomeMetrics()
{
_sut.Add("metric1", 100);
_sut.Add("metric2", 200);
_sut.Add("metric3", 300);
}

[When]
public void WhenToStringIsInvoked()
{
_result = _sut.ToString();
}

[Then]
public void ThenTheMetricsAreFormattedCorrectly()
{
Assert.That(_result, Is.EqualTo("metric1: 100ms, metric2: 200ms, metric3: 300ms"));
Expand All @@ -42,18 +39,15 @@ public class HasNoMetrics
private readonly Metrics _sut = new();
private string _result;

[Given]
public void GivenThereAreSomeMetrics()
{
}

[When]
public void WhenToStringIsInvoked()
{
_result = _sut.ToString();
}

[Then]
public void ThenTheMetricsAreFormattedCorrectly()
{
Assert.That(_result, Is.EqualTo(""));
Expand Down
18 changes: 0 additions & 18 deletions .../Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs/Parsing/HtmlParserSpecs.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@ class SelfClosingTags
private HtmlParser _sut;
private readonly List<HtmlTag> _tags = new List<HtmlTag>();

[Given]
public void GivenHtmlContainsSelfClosingTags()
{
_sut = new HtmlParser(SpecHelper.GetFile("Parsing/Files/Self-closing-tags.html"));
}

[When]
public void WhenTheHtmlIsParsed()
{
while (_sut.ParseNext(
Expand All @@ -30,7 +28,6 @@ public void WhenTheHtmlIsParsed()
}
}

[Then]
public void ThenTheTagsAreExtracted()
{
Assert.That(_tags, Has.Count.EqualTo(3));
Expand All @@ -51,13 +48,11 @@ class EndTags
private HtmlParser _sut;
private readonly List<HtmlTag> _tags = new List<HtmlTag>();

[Given]
public void GivenHtmlContainsTagsWithEndTags()
{
_sut = new HtmlParser(SpecHelper.GetFile("Parsing/Files/End-tags.html"));
}

[When]
public void WhenTheHtmlIsParsed()
{
while (_sut.ParseNext(
Expand All @@ -71,7 +66,6 @@ public void WhenTheHtmlIsParsed()
}
}

[Then]
public void ThenTheTagsAreExtracted()
{
Assert.That(_tags, Has.Count.EqualTo(3));
Expand All @@ -94,13 +88,11 @@ class NonClosedTags
private HtmlParser _sut;
private readonly List<HtmlTag> _tags = new List<HtmlTag>();

[Given]
public void GivenHtmlContainsNonClosedTags()
{
_sut = new HtmlParser(SpecHelper.GetFile("Parsing/Files/Non-closed-tags.html"));
}

[When]
public void WhenTheHtmlIsParsed()
{
while (_sut.ParseNext(
Expand All @@ -114,7 +106,6 @@ public void WhenTheHtmlIsParsed()
}
}

[Then]
public void ThenTheTagsAreExtracted()
{
Assert.That(_tags, Has.Count.EqualTo(2));
Expand All @@ -134,13 +125,11 @@ class NoClosingBracket
private HtmlParser _sut;
private readonly List<HtmlTag> _tags = new List<HtmlTag>();

[Given]
public void GivenHtmlContainsATagWithoutAClosingBracket()
{
_sut = new HtmlParser(SpecHelper.GetFile("Parsing/Files/Invalid-tag-with-no-closing-bracket.html"));
}

[When]
public void WhenTheHtmlIsParsed()
{
while (_sut.ParseNext(
Expand All @@ -154,7 +143,6 @@ public void WhenTheHtmlIsParsed()
}
}

[Then]
public void ThenTheTagIsIgnored()
{
Assert.That(_tags, Has.Count.EqualTo(0));
Expand All @@ -172,14 +160,12 @@ class LastTagWithNoClosingBracket
private HtmlParser _sut;
private readonly List<HtmlTag> _tags = new List<HtmlTag>();

[Given]
public void GivenHtmlContainsAnEndTagWithoutAClosingBracket()
{
_sut = new HtmlParser(
SpecHelper.GetFile("Parsing/Files/Invalid-last-tag-with-no-closing-bracket.html"));
}

[When]
public void WhenTheHtmlIsParsed()
{
while (_sut.ParseNext(
Expand All @@ -193,7 +179,6 @@ public void WhenTheHtmlIsParsed()
}
}

[Then]
public void ThenTheTagIsIgnored()
{
Assert.That(_tags, Has.Count.EqualTo(0));
Expand All @@ -211,13 +196,11 @@ class InvalidAttributes
private HtmlParser _sut;
private readonly List<HtmlTag> _tags = new List<HtmlTag>();

[Given]
public void GivenHtmlContainsATagWithInvalidAttributes()
{
_sut = new HtmlParser(SpecHelper.GetFile("Parsing/Files/Tag-with-invalid-attributes.html"));
}

[When]
public void WhenTheHtmlIsParsed()
{
while (_sut.ParseNext(
Expand All @@ -231,7 +214,6 @@ public void WhenTheHtmlIsParsed()
}
}

[Then]
public void ThenTheTagIsIgnored()
{
Assert.That(_tags, Has.Count.EqualTo(0));
Expand Down
3 changes: 0 additions & 3 deletions ...evelopment.Unit.Specs/Resolving/GenericResponseResolverSpecs/ResolveEncodedStaticPaths.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,11 @@ class ResolveEncodedStaticPaths
private readonly Guid _blockVersionId = Guid.NewGuid();
private readonly Guid _projectUuid = Guid.NewGuid();

[Given]
public void GivenTheGenericResponseResolver()
{
_sut = new GenericResponseResolver();
}

[When]
public async void WhenAResponseContainsStaticLinks()
{
var html = SpecHelper.GetFile("Resolving/Files/encoded.json");
Expand All @@ -28,7 +26,6 @@ public async void WhenAResponseContainsStaticLinks()
_result = await _sut.Resolve(html, routeInfo, 0, CancellationToken.None);
}

[Then]
public void ThenTheStaticPathsAreRewrittenWithABlockVersionIdPrefix()
{
var expected =
Expand Down
4 changes: 0 additions & 4 deletions ....LocalDevelopment.Unit.Specs/Resolving/GenericResponseResolverSpecs/ResolveStaticPaths.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,11 @@ class ResolveStaticPaths
private readonly Guid _blockVersionId = Guid.NewGuid();
private readonly Guid _projectUuid = Guid.NewGuid();

[Given]
public void GivenTheGenericResponseResolver()
{
_sut = new GenericResponseResolver();
}

[When]
public async void WhenAResponseContainsStaticLinks()
{
var html = SpecHelper.GetFile("Resolving/Files/site.css");
Expand All @@ -28,15 +26,13 @@ public async void WhenAResponseContainsStaticLinks()
_result = await _sut.Resolve(html, routeInfo, 0, CancellationToken.None);
}

[Then]
public void ThenTheTargetedStaticPathsAreRewrittenWithABlockVersionIdPrefix()
{
var expected =
$"url(\"/{Constants.Paths.StaticPathUniquePrefix}{RouteInfo.GetUrlFriendlyHash(_projectUuid)}{Constants.Paths.StaticPathUniquePrefix}{_blockVersionId}/static/css/cat.png\")";
Assert.That(_result, Contains.Substring(expected));
}

[AndThen]
public void AndThenTheRestOfTheStaticPathsAreNotRewritten()
{
var expectedUrls = new[]
Expand Down
Loading

0 comments on commit 1ed6ea7

Please sign in to comment.