fix: parse image tags with transformations #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… markup attribute
…ent project id in new recorded mocks than was originally used
nflatley-zengenti
added
html-canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpdesk 58319
Two issues here:
the provided DataResolver function in
html-canvasis not considering a querystring may be attached to the inbound path parsed from the html when resolving images by sys.uri - added more ways to search for an asset and added comments providing example inputswith the above fix we can now resolve the image but the transformations are still not applied to the canvas output
I have added a test to check for image transformations in a resolved image and it is failing.
The CI in this branch should complete successfully when the second issue is fixed.