Use krun_add_disk and increase SHM window size #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new krun_add_disk API, introduced in libkrun 1.9.5, to be able to add an arbitrary number of virtio-blk devices. Signed-off-by: Sergio Lopez <[email protected]>
On version 1.9.5 libkrun introduced an API to set the size of the SHM window for virtio-gpu. Use it to set it to be as large as the host's RAM. This should give us enough room for running large models, accounting for potential device memory fragmentation. Signed-off-by: Sergio Lopez <[email protected]>
Signed-off-by: Sergio Lopez <[email protected]>
tylerfanelli
approved these changes
Oct 1, 2024
|
@slp Does this warrant a 0.1.3 GH release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.