-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Install with fsverity #935
base: main
Are you sure you want to change the base?
Conversation
Needs a rebase, conflicts should be relatively straightforward to fix |
Can you explain some scenarios where we might want to have fs-verity disabled? Is it just on filesystems that can't support it? Because even without checking the verity data or anything, I find the "this inode is now immutable" thing to be extremely compelling, particularly in the presence of multiple hardlinks.... |
That's by far the biggest case. However, there is some generic overhead to having it...this isn't quite as relevant for bootc but it would be for taking fsverity in container runtimes in general. There are people that disable selinux to claw back like 1-2% of performance and fsverity is a bit like that, you just have this cost to paging in new code and doing cryptographic verification. But supporting deploying to filesystems without it is 94.3% of the rationale for bootc.
Definitely! Before composefs existed I was trying to push for fsverity in ostree just for this reason...but I struggled with tying it to a higher level integrity story. Thankfully we have that now! |
8379be7
to
d045510
Compare
280cbe6
to
b7cfe64
Compare
TODO: Also check for ostreedev/ostree#3354 - if that's set then we should key off it too. In fact, maybe that should be the sole interface for now. |
403be9a
to
0cea6bc
Compare
Signed-off-by: Colin Walters <[email protected]>
Prep for further work. Signed-off-by: Colin Walters <[email protected]>
Prep for using this to determine fsverity. Signed-off-by: Colin Walters <[email protected]>
And expose some fsverity helpers. This is just to get the ball rolling on integration. Signed-off-by: Colin Walters <[email protected]>
Key off the ostree prepare-root config to require fsverity on all objects. As part of this: - Add a dependency on composefs-rs just for the fsverity querying APIs, and as prep for further integration. - Add `bootc internals fsck`, which verifies the expected fsverity state. Signed-off-by: Colin Walters <[email protected]>
In case we have e.g. ostree updates added. Signed-off-by: Colin Walters <[email protected]>
0cea6bc
to
d32c973
Compare
The goal of this PR is to enable in an install config:
to hard require fsverity for
bootc install
, and chain it to the ostree config. We're trying to hide the ostree configuration here though.