-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootc-fetch-apply-updates.timer with comments for RandomizedDe… #295
Conversation
Hi @mrguitar. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test 👍 from me, reminds me of messing with cfengine splaytime many moons ago! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of turning it on by default actually...there's not really a strong downside right?
@jeckersb exactly! I always describe this as "splay"! @cgwalters, I can't think of a downside. Maybe the comment should change to this if we enable it: "When deploying a large number of systems, it may be beneficial to increase this value to help with load on the registry." I think 2h is a sane default, but I just put that as an example. Should it change? |
ok, I tried to make that change, but since I suck at git it's stuck on DCO. :) This is what PM help looks like. lol |
See https://docs.pi-hole.net/guides/github/how-to-signoff/ TL;DR do |
RandomizedDelaySec= is the best kept secret of timers. Signed-off-by: Ben Breard <[email protected]> Signed-off-by: Colin Walters <[email protected]>
I force pushed an update to this:
|
…laySec=
RandomizedDelaySec= is the best kept secret of timers. Given that such few people know about it and it's very useful for large deployments, I think it makes sense to add it as a comment.
Thoughts about providing this out of the box as a comment? I'm not proposing we turn it on by default.