reinstall: avoid duplicate users in loginctl_users
#1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because still testing |
cgwalters
requested changes
Feb 7, 2025
| use std::fmt::Display; | ||
| use std::fmt::Formatter; | ||
| use std::process::Command; | ||
| use uzers::os::unix::UserExt; | ||
|
|
||
| fn loginctl_users() -> Result<Vec<String>> { | ||
| fn loginctl_users() -> Result<HashSet<String>> { |
There was a problem hiding this comment.
Probably better to use BTreeSet so the order isn't random.
As far as testing, one pattern we use elsewhere with code like this is to have a unit test with some example output as a fixture. See the blockdev code for that.
See containers#1093 Signed-off-by: Omer Tuchfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1093