tar/export: Fix error with zero-sized hardlinked files #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Walters <[email protected]>
In the case where we already emitted an object into the tar stream, we wouldn't previously set the file type and size into the tar header structure that we passed into the hardlink emission function. This would cause an error when accessing the (logically) uninitialized `size()`. Fix the writer function to always set the file type and size unconditionally, and also rework the consumer side to make the logic even clearer. Signed-off-by: Colin Walters <[email protected]>
|
Just ran into this myself while testing coreos/rpm-ostree#5275, gonna pull this in and sanity check it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar/export: Add error context
Signed-off-by: Colin Walters [email protected]
tar/export: Fix error with zero-sized hardlinked files
In the case where we already emitted an object into the tar stream,
we wouldn't previously set the file type and size into the tar
header structure that we passed into the hardlink emission function.
This would cause an error when accessing the (logically) uninitialized
size().Fix the writer function to always set the file type and size unconditionally,
and also rework the consumer side to make the logic even clearer.
Signed-off-by: Colin Walters [email protected]