Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ostree-ext: Add image clear-cached-update #1071

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

cgwalters
Copy link
Collaborator

This is effectively an internals command for us to aid debugging.

At some point it may make sense to expose this
at the bootc level too.

This is effectively an internals command for us to aid
debugging.

At some point it may make sense to expose this
at the bootc level too.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters requested a review from jeckersb February 3, 2025 16:05
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

return Ok(());
};

// SAFETY: We know this is an a{sv}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what a{sv} means here, not a blocker but please enlighten me 😃

Copy link
Collaborator Author

@cgwalters cgwalters Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gvariant is a bit like a binary JSON, although also with a richer type system (e.g. 32 and 64 bit signed/unsigned integers, not just "number" etc.).

See https://docs.gtk.org/glib/gvariant-format-strings.html - specifically a{sv} is a lot like a default json dictionary (string keys, heterogeneous values).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the lesson 🎓

@cgwalters cgwalters merged commit 02d5cd3 into containers:main Feb 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants