New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Don't use inline const to preserve compat with rust 1.78 #1061

Closed

jmarrero wants to merge 1 commit into containers:main from jmarrero:const-inline-nomore

Member

jmarrero commented Jan 26, 2025

An attempt to fix build failure on: coreos/rpm-ostree#5253

jmarrero force-pushed the const-inline-nomore branch from 34c92bd to c7d08f2 Compare

January 26, 2025 18:17


          misc: Don't use inline const to preserve compat with rust 1.78

bc3b589

Signed-off-by: Joseph Marrero Corchado <[email protected]>

jmarrero force-pushed the const-inline-nomore branch from c7d08f2 to bc3b589 Compare

January 26, 2025 18:19

Collaborator

cgwalters commented Jan 26, 2025

Thanks for looking at this. I'm not opposed but we should have newer rust; 1.78 is more than 8 months old now.

I pushed a different attempted fix for this in coreos/rpm-ostree@8ba6c2d

jmarrero closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet