baseimage: Add kernel-install integration #1018
Conversation
There was a problem hiding this comment.
The base directory is for things that are truly hard requirements and also currently has some special handling at install time (see the Makefile...it's hacky).
For people who are making "sealed" images, they don't actually need to ship kernel-install in their images - i.e. for users who don't want to support having their images be used for derivation, they don't need it.
We do have the dracut directory, which this is related to but there are people using other initramfs generators too.
Logically this is configuration for systemd (of which kernel-install is a part).
Maybe what would make the most sense is to create a new systemd directory which configures/tweaks things shipped by systemd.
That'd be a great place to put the systemd journal persistence config too.
jmarrero
force-pushed
the
baseimage-kernel
branch
2 times, most recently
from
57ac0ea to
498b0be
Compare
|
I will add the journal one in a separate PR with its corresponding MR for the base image removing it there. Just to keep things separate. |
jmarrero
force-pushed
the
baseimage-kernel
branch
from
498b0be to
862b258
Compare
|
Looks sane to me, I think we just need an update to the |
jmarrero
force-pushed
the
baseimage-kernel
branch
4 times, most recently
from
43053f9 to
650a2d9
Compare
|
ok, I added the changes to the Makefile too following what we do for Dracut, but the question is, if that should be behind some flag since it's technically optional? Or maybe I misunderstood about needing to add this to the Makefile. |
jmarrero
force-pushed
the
baseimage-kernel
branch
from
650a2d9 to
443a55f
Compare
|
Note that everything in the baseimage directory is installed into So this can't break anything today. The changes LGTM as is! |
Added a kernel-install configuration that enables the rpm-ostree integration. The second configuration file sets the Journal to persistent as on bootc systems /var is empty by default and systemd by default enables persistent journaling on the presence of /var/log/journal. Signed-off-by: Joseph Marrero Corchado <[email protected]>
jmarrero
force-pushed
the
baseimage-kernel
branch
from
443a55f to
d603e9e
Compare
|
Ok, cool, I re-read the Makefile as you were typing :D and noticed the doc, but that makes sense now I will leave this PR alone then. |
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
This is part of the kernel-install integration work done in: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/62 coreos#5135 containers/bootc#1018
|
Since this is informational at the moment, we should be good to merge this here. |
This is part of the kernel-integration work:
WIP while we release rpm-ostree.