Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A generic version of #897 using the
storage
abstractions instead ofrocksdb
directly.The PR isn't finished, I just wanted to see what were the problems that stopped @fridrik01 from using the
KVStore
. I won't lie it's a lot of generics; in a way the syncer is the one of the worst places to introduce this kind of stuff because it's layers and layers of indirection.I tried to alleviate it a little by removing the
S
parameter fromApp
. I imagine it might help to try to wrap things up into abstractions that do a specific cache functionality, rather than having to pass around aKVStore
parameter together with all the things that it needs to be able to serialize. But I wanted to do this to show the way it can be done.Had to refactor STM a bit in aakoshh/async-stm-rs@113be84 to get around a compilation issue. This now demonstrates how to use RocksDB transactions together with STM ones. There might be ways to refactor the panicky commit/rollback, just need to have another long look at how they are used.