Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push the latest contracts #516

Merged
merged 27 commits into from
Jan 10, 2024
Merged

Push the latest contracts #516

merged 27 commits into from
Jan 10, 2024

Conversation

dnkolegov
Copy link
Contributor

@dnkolegov dnkolegov commented Jan 8, 2024

Push the latest contracts from the upstream and update the code that calls the contracts.

snissn and others added 8 commits December 21, 2023 12:38
Signed-off-by: Alfonso de la Rocha <[email protected]>
Co-authored-by: snissn <[email protected]>
Co-authored-by: auto-commit <[email protected]>
Co-authored-by: Alfonso de la Rocha <[email protected]>
Co-authored-by: adlrocha <[email protected]>
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
Split Subnet Actor manager
This PR establishes a skeleton for future invariant tests for
GatewayActor.
The main idea is to define all basic properties of the gatewayActor and
be able to apply them to many different Gateway instances with different
configurations.
Copy link
Contributor

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the instructions in the README to absorb the commit history from the original repo instead?

@dnkolegov dnkolegov requested a review from raulk January 8, 2024 16:00
@dnkolegov
Copy link
Contributor Author

Can you use the instructions in the README to absorb the commit history from the original repo instead?

Done.

@@ -0,0 +1,44 @@
name: Build and Test Workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be integrated in the repo's GitHub workflows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll move this file to a top-level dir, but it's fine here for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll move this file to a top-level dir, but it's fine here for now.

@dnkolegov dnkolegov merged commit 62f0d64 into main Jan 10, 2024
21 checks passed
Comment on lines +63 to +64
s.SUBNET_ACTOR_CHECKPOINTING_FACET = params.checkpointerFacet;
s.SUBNET_ACTOR_PAUSE_FACET = params.pauserFacet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting the different words, PAUSE vs pauser, CHECKPOINTING vs checkpointer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants