-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push the latest contracts #516
Conversation
Co-authored-by: raulk <[email protected]>
Signed-off-by: Alfonso de la Rocha <[email protected]> Co-authored-by: snissn <[email protected]> Co-authored-by: auto-commit <[email protected]> Co-authored-by: Alfonso de la Rocha <[email protected]> Co-authored-by: adlrocha <[email protected]> Co-authored-by: raulk <[email protected]> Co-authored-by: raulk <[email protected]>
Split Subnet Actor manager
This PR establishes a skeleton for future invariant tests for GatewayActor. The main idea is to define all basic properties of the gatewayActor and be able to apply them to many different Gateway instances with different configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the instructions in the README to absorb the commit history from the original repo instead?
f4feb8e
to
4854744
Compare
Done. |
@@ -0,0 +1,44 @@ | |||
name: Build and Test Workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be integrated in the repo's GitHub workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll move this file to a top-level dir, but it's fine here for now.
contracts/ops/deploy-subnet.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll move this file to a top-level dir, but it's fine here for now.
s.SUBNET_ACTOR_CHECKPOINTING_FACET = params.checkpointerFacet; | ||
s.SUBNET_ACTOR_PAUSE_FACET = params.pauserFacet; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting the different words, PAUSE
vs pauser
, CHECKPOINTING
vs checkpointer
Push the latest contracts from the upstream and update the code that calls the contracts.