Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contracts auto-deploy GitHub Actions workflow #1238

Merged
merged 14 commits into from
Dec 23, 2024
Merged

Conversation

raulk
Copy link
Contributor

@raulk raulk commented Dec 19, 2024

This fixes our GitHub Actions workflow to auto-deploy contracts to Calibnet when changes are detected. This has been failing for some months and we never got around to fixing it. New users kept tripping up regularly when following the quickstart tutorial @ docs.ipc.space, which instructs them to deploy their subnet against the existing framework contracts on Calibnet. However, those contracts were outdated leading to severe compatibility issues.

While fixing this, I also:

  • Simplified the setup by removing the need for a PAT.
  • Removed the merge from main, as GH rejected pushes containing modified workflow files.
  • Introduce a cache for incremental compilation and deployment (leveraging hardhat-deploy's ability to skip deployment when a contract with the same bytecode already exists).
  • Eliminate random env variables carrying addresses and stdout parsing; instead just read the addresses from the deployment output files and generate a JSON file.

@raulk raulk requested a review from a team as a code owner December 19, 2024 11:36
@raulk raulk force-pushed the raulk/fix/auto-deploy branch from 999e799 to 3c57089 Compare December 19, 2024 11:41
@raulk raulk changed the title fix: contracts auto-deploy GitHub Actions script fix: contracts auto-deploy GitHub Actions workflow Dec 23, 2024
@raulk raulk merged commit 9835437 into main Dec 23, 2024
18 checks passed
@raulk raulk deleted the raulk/fix/auto-deploy branch December 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant