Skip to content

Commit

Permalink
fix(contracts/sdk): IpcUpgradableOwnable: pass msg.sender to `Own…
Browse files Browse the repository at this point in the history
…able` `init` for compatibility with OZ v5 (#1018)
  • Loading branch information
lordshashank authored Jun 1, 2024
1 parent 0086935 commit 8188e25
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/contracts-prettier.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
ref: ${{ github.ref }}
- name: Set up node.js
uses: actions/setup-node@v4
with:
node-version: '21'
node-version: "21"
- name: Run formatter
run: cd contracts && make fmt
- name: Check diff clean
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/contracts-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.ref }}
ref: ${{ github.ref }}
submodules: recursive

- name: Install python
uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: "3.10"

- name: Install abi
run: pip install eth_abi

- name: Install lcov and genhtml
run: sudo apt-get update && sudo apt-get -y install lcov
run: sudo apt-get update && sudo apt-get -y install lcov

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
Expand Down
2 changes: 1 addition & 1 deletion contracts/sdk/IpcContractUpgradeable.sol
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ abstract contract IpcExchangeUpgradeable is Initializable, IIpcHandler, OwnableU

function __IpcExchangeUpgradeable_init(address gatewayAddr_) public onlyInitializing {
gatewayAddr = gatewayAddr_;
__Ownable_init();
__Ownable_init(msg.sender);
__ReentrancyGuard_init();
}

Expand Down

0 comments on commit 8188e25

Please sign in to comment.