fix: reject block if it includes messages below the base fee.

consensus-shipyard · Dec 19, 2024 · 7e4b87c · 7e4b87c
1 parent 94ec24f
commit 7e4b87c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/fendermint/actors/api/src/gas_market.rs b/fendermint/actors/api/src/gas_market.rs
@@ -16,6 +16,8 @@ pub struct Reading {
     pub block_gas_limit: Gas,
     /// The current base fee for the block.
     pub base_fee: TokenAmount,
+    /// The minimum allowable base fee.
+    pub min_base_fee: TokenAmount,
 }
 
 /// The current utilization for the client to report to the gas market.

diff --git a/fendermint/actors/gas_market/eip1559/src/lib.rs b/fendermint/actors/gas_market/eip1559/src/lib.rs
@@ -97,6 +97,7 @@ impl fendermint_actors_api::gas_market::GasMarket for Actor {
         Ok(fendermint_actors_api::gas_market::Reading {
             block_gas_limit: st.constants.block_gas_limit,
             base_fee: st.base_fee,
+            min_base_fee: st.constants.minimal_base_fee,
         })
     }
 
@@ -111,6 +112,7 @@ impl fendermint_actors_api::gas_market::GasMarket for Actor {
             Ok(fendermint_actors_api::gas_market::Reading {
                 block_gas_limit: st.constants.block_gas_limit,
                 base_fee: st.base_fee.clone(),
+                min_base_fee: st.constants.minimal_base_fee.clone(),
             })
         })
     }
@@ -229,10 +231,10 @@ mod tests {
         let r = rt.call::<Actor>(
             Method::SetConstants as u64,
             IpldBlock::serialize_cbor(&Constants {
-                minimal_base_fee: Default::default(),
                 elasticity_multiplier: 0,
                 base_fee_max_change_denominator: 0,
                 block_gas_limit: 20,
+                ..Default::default()
             })
             .unwrap(),
         );
@@ -266,6 +268,7 @@ mod tests {
             .unwrap();
         let reading = r.deserialize::<Reading>().unwrap();
         assert_eq!(reading.base_fee, TokenAmount::from_atto(112));
+        assert_eq!(reading.min_base_fee, Constants::default().minimal_base_fee)
     }
 
     #[test]
@@ -292,6 +295,7 @@ mod tests {
             .unwrap();
         let reading = r.deserialize::<Reading>().unwrap();
         assert_eq!(reading.base_fee, TokenAmount::from_atto(100));
+        assert_eq!(reading.min_base_fee, Constants::default().minimal_base_fee)
     }
 
     #[test]
@@ -318,6 +322,7 @@ mod tests {
             .unwrap();
         let reading = r.deserialize::<Reading>().unwrap();
         assert_eq!(reading.base_fee, TokenAmount::from_atto(88));
+        assert_eq!(reading.min_base_fee, Constants::default().minimal_base_fee)
     }
 
     #[test]

diff --git a/fendermint/vm/interpreter/src/chain.rs b/fendermint/vm/interpreter/src/chain.rs
@@ -190,6 +190,7 @@ where
         msgs: Vec<Self::Message>,
     ) -> anyhow::Result<bool> {
         let mut block_gas_usage = 0;
+        let base_fee = state.block_gas_tracker().base_fee();
 
         for msg in msgs {
             match msg {
@@ -228,6 +229,12 @@ where
                     }
                 }
                 ChainMessage::Signed(signed) => {
+                    if &signed.message.gas_fee_cap < base_fee {
+                        // We do not accept blocks containing transactions with gas parameters below the current base fee.
+                        // Producing an invalid block like this should penalize the validator going forward.
+                        return Ok(false);
+                    }
+
                     block_gas_usage += signed.message.gas_limit;
                 }
                 _ => {}